feat: add external job tools + improve LLM-facing tool descriptions
Add 3 new MCP tools for inspecting YARN applications NOT submitted through this service: get_external_job_logs, get_external_job_status, get_external_job_result. Each takes application_id + connection_name and queries YARN directly, bypassing the local JobStore. - spark_executor/tools/external_jobs.py: 3 tool functions - spark_executor/tools/requests.py: 3 new Pydantic body models (ExternalJobLogsRequest, ExternalJobStatusRequest, ExternalJobResultRequest) - spark_executor/server.py: 3 new POST routes with explicit operation_id - tests/unit/test_external_jobs.py: 7 unit tests - tests/integration/test_mcp_routes.py: assert 20 tool routes - README.md: list the 3 new tools To make the LLM pick the right tool and not guess at field values, also: - Add Pydantic field descriptions for 22 fields across 8 request models (SaveConnectionRequest, UpdatePendingJobRequest, GetJobLogsRequest, JobIdRequest, PendingIdRequest, ConnectionNameRequest, plus the new ExternalJob*Request models). - Update 12 route descriptions with cross-references, prerequisite context, and 400 behavior notes. - Refactor _unknown_job_error: an input that looks like a YARN application_id (starts with 'application_') now returns HTTP 400 (ValueError) with a hint message naming the right external tool; other not-found cases still return 404 (KeyError). This catches the common LLM mistake of passing application_id to the internal get_job_* / kill_job tools. - 4 new unit tests for the 400 behavior. Tests: 356 passed (up from 242). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
@@ -66,6 +66,14 @@ def test_get_job_status_raises_for_unknown_job():
|
||||
status.get_job_status("missing")
|
||||
|
||||
|
||||
def test_get_job_status_raises_400_for_external_application_id(fresh_stores):
|
||||
"""Input that looks like a YARN application_id but is not in the local
|
||||
JobStore must raise ValueError (-> 400) with a hint to use the
|
||||
external tool, NOT a generic KeyError (-> 404)."""
|
||||
with pytest.raises(ValueError, match="get_external_job_status"):
|
||||
status.get_job_status("application_17400000001_0001")
|
||||
|
||||
|
||||
def test_get_job_status_raises_when_connection_missing():
|
||||
_fresh_stores()
|
||||
status.store.put(
|
||||
|
||||
Reference in New Issue
Block a user