feat(connection): add history_server_url config field
Add a new optional field to Connection for the Spark History Server
base URL. The field is stored as part of the connection but is not
yet consumed by any tool — for now it's a labeled place to record
where SHS lives on the cluster, and a hook for future SHS-specific
tools. To actually fetch SHS endpoints today, use fetch_url with the
SHS host added to url_allowlist.
The field is Optional[str], default None. Same nullability as
yarn_rm_url. The SHS host and the YARN RM host are usually
different, so this is independent of yarn_rm_url.
Schema:
- models.py: Connection.history_server_url (str | None, default None)
- requests.py:
- SaveConnectionRequest.history_server_url (str | None, default None)
- UpdateConnectionRequest.history_server_url (str | None, default None)
- tools/connections.py: save_connection signature gains
history_server_url with the _UNSET sentinel pattern (same as
yarn_rm_url, url_allowlist, etc.) so the upsert path correctly
distinguishes "not provided" from "explicitly None".
- tools/connections.py: update_connection docstring lists the new
field in the mutable fields set.
Tests (4 new in tests/unit/test_connection_tools.py):
- test_save_connection_with_history_server_url
- test_save_connection_history_server_url_defaults_to_none
- test_update_connection_changes_history_server_url
- test_update_connection_keeps_history_server_url_when_omitted
Tests: 398 passed (was 394, +4 net).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
@@ -106,6 +106,18 @@ class Connection(BaseModel):
|
||||
"'ccam50' but not 'ccam50.evil.com'."
|
||||
),
|
||||
)
|
||||
history_server_url: str | None = Field(
|
||||
default=None,
|
||||
description=(
|
||||
"Optional Spark History Server (SHS) base URL, e.g. "
|
||||
"'http://history.prod.internal:18080'. Stored as part of the "
|
||||
"connection for reference and to be consumed by future SHS-"
|
||||
"specific tools. Currently **not consumed by any tool** — to "
|
||||
"fetch SHS endpoints today, use fetch_url with the SHS host "
|
||||
"added to url_allowlist. The SHS host and the YARN RM host "
|
||||
"are usually different, so this is independent of yarn_rm_url."
|
||||
),
|
||||
)
|
||||
|
||||
@field_validator("master")
|
||||
@classmethod
|
||||
|
||||
Reference in New Issue
Block a user