tao.chen/notebook-ai-extension
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

fix: Provider.models is a Record keyed by modelID, not an array

Browse Source 
Per the OpenCode server docs (GET /config/providers), each Provider's
'models' is { [modelID: string]: Model } (a Record), so model IDs can be
referenced as strings (matching the 'default' map of providerID ->
modelID). Our code treated it as Model[], which:
  1. crashed with 'p.models is not iterable' on real responses, and
  2. after the previous Array.isArray guard, skipped EVERY provider
     (a Record is never an array), so the inline picker showed nothing.

Update types.ts (OpenCodeProvider.models -> Record, add OpenCodeModel,
add optional 'default' map to the response) and rewrite
flattenProviders to iterate Object.keys(p.models). Update test fixture
to the Record shape.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
tao.chen
2026-07-23 18:01:16 +08:00
co-authored by Claude Fable 5
parent f7099be060
commit e7579d3779
3 changed files with 29 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/components/opencode_inline_prompt.ts
+5 -6
View File
@@ -114,14 +114,13 @@ function flattenProviders(
}
const out: { providerId: string; modelId: string }[] = [];
for (const p of providers.providers) {
// Some OpenCode Serve responses include providers without a `models`
// field (or with a non-array value). Guard to avoid the "p.models is
// not iterable" crash and simply skip such providers in the picker.
if (!Array.isArray(p.models)) {
// Per the OpenCode server docs, Provider.models is a Record keyed by
// modelID ({ [modelID: string]: Model }), NOT an array.
if (!p.models || typeof p.models !== "object") {
continue;
}
for (const m of p.models) {
out.push({ providerId: p.id, modelId: m.id });
for (const modelId of Object.keys(p.models)) {
out.push({ providerId: p.id, modelId });
}
}
return out;