The PTY was hardcoded to 80x24 at start, so full-screen programs
(htop, vim, less, tmux, top) drew themselves for 80x24 regardless
of the actual xterm window. Add a path for the frontend to push the
real cols/rows to the backend, which calls pty.Setsize on the pty
file.
Backend:
- internal/shell/manager.go: Resize(workspaceID, cols, rows) added to
the Manager interface and implemented on LocalManager. Looks up the
session, type-asserts sess.Stdin.(*os.File), calls pty.Setsize.
Validates cols/rows in [1, 10000] and returns CodeBadRequest on
bad input, CodeNotFound when no session.
- internal/service/shell_service.go: ShellService.Resize wrapper that
checks workspace existence first.
- internal/api/shell_handler.go: resize handler, 204 on success.
- internal/api/router.go: register POST /workspaces/:id/shell/resize.
- internal/model/shell.go: ShellResizeRequest{Cols, Rows}.
- internal/shell/manager_test.go: 3 new tests (valid resize via
pty.Getsize round-trip, invalid size, missing session).
Frontend:
- web/src/lib/api/process.ts: useShellResize mutation hook.
- web/src/components/terminal/TerminalPanel.tsx: terminal.onResize
subscription with 100ms debounce; filters 0x0; only fires when
workspaceId is set; cleanup clears timeout + disposes listener.
E2E: 'stty size' after POST /shell/resize {cols:200, rows:50} returns
'50 200'. 0x40 → 400, missing workspace → 404, valid → 204.
Conversation: 019f360a-5eba-7c81-94d3-e5d58ad3c026
64 lines
2.3 KiB
Go
64 lines
2.3 KiB
Go
package api
|
|
|
|
import (
|
|
"log/slog"
|
|
"net/http"
|
|
|
|
"codespace/internal/service"
|
|
|
|
"github.com/gin-gonic/gin"
|
|
)
|
|
|
|
// NewRouter builds a Gin engine with all API routes registered.
|
|
func NewRouter(workspaces *service.WorkspaceService, files *service.FileService, processes *service.ProcessService, shells *service.ShellService, acpSvc *service.AcpService, lg *slog.Logger, ginMode string) *gin.Engine {
|
|
gin.SetMode(ginMode)
|
|
r := gin.New()
|
|
r.Use(gin.Recovery())
|
|
r.Use(requestLogger(lg))
|
|
|
|
wsHandler := &workspaceHandler{svc: workspaces}
|
|
fileHandler := &fileHandler{svc: files}
|
|
procHandler := &processHandler{svc: processes}
|
|
shellHandler := &shellHandler{svc: shells}
|
|
acpHandler := &acpHandler{svc: acpSvc}
|
|
|
|
r.GET("/healthz", healthHandler)
|
|
|
|
api := r.Group("/api")
|
|
api.GET("/workspaces", wsHandler.list)
|
|
api.POST("/workspaces", wsHandler.create)
|
|
api.GET("/workspaces/:id", wsHandler.get)
|
|
api.DELETE("/workspaces/:id", wsHandler.delete)
|
|
|
|
api.GET("/workspaces/:id/files", fileHandler.list)
|
|
api.GET("/workspaces/:id/files/read", fileHandler.read)
|
|
api.GET("/workspaces/:id/files/stat", fileHandler.stat)
|
|
api.PUT("/workspaces/:id/files/write", fileHandler.write)
|
|
api.POST("/workspaces/:id/files/mkdir", fileHandler.mkdir)
|
|
api.DELETE("/workspaces/:id/files", fileHandler.remove)
|
|
api.POST("/workspaces/:id/files/rename", fileHandler.rename)
|
|
|
|
api.POST("/workspaces/:id/process/start", procHandler.start)
|
|
api.POST("/workspaces/:id/process/stop", procHandler.stop)
|
|
api.POST("/workspaces/:id/process/restart", procHandler.restart)
|
|
api.GET("/workspaces/:id/process/status", procHandler.status)
|
|
api.GET("/workspaces/:id/process/ws", procHandler.ws)
|
|
|
|
api.POST("/workspaces/:id/shell/start", shellHandler.start)
|
|
api.POST("/workspaces/:id/shell/stop", shellHandler.stop)
|
|
api.POST("/workspaces/:id/shell/restart", shellHandler.restart)
|
|
api.GET("/workspaces/:id/shell/status", shellHandler.status)
|
|
api.GET("/workspaces/:id/shell/ws", shellHandler.ws)
|
|
api.POST("/workspaces/:id/shell/resize", shellHandler.resize)
|
|
api.GET("/workspaces/:id/acp/status", acpHandler.status)
|
|
api.GET("/workspaces/:id/acp/history", acpHandler.history)
|
|
api.POST("/workspaces/:id/acp/prompt", acpHandler.prompt)
|
|
api.POST("/workspaces/:id/acp/cancel", acpHandler.cancel)
|
|
|
|
return r
|
|
}
|
|
|
|
func healthHandler(c *gin.Context) {
|
|
c.JSON(http.StatusOK, gin.H{"status": "ok"})
|
|
}
|