b10fae5fd18b8aa4995899458984e147ed6b8e82
The previous commit (32ee167) added a regex-based HTML directory-listing parser as a fallback when the NodeManager wraps /stdout in HTML (Knox, wrapped vendor YARN builds). On review, the parser is too brittle to trust in production: - Apache-style listings vary across Hadoop distributions; some add extra rows, icons, or anchors that change the regex hit set. - Some clusters return the listing but 4xx each individual log file (auth layer in the way), so the fallback silently returns empty. - The behavior the agent observes for the same application_id becomes environment-dependent in ways that are hard to reason about. Revert to the simple, predictable path: GET /apps/{appid}, read amContainerLogs, GET {amContainerLogs}/stdout, return its text. If the cluster wraps /stdout in HTML, the agent gets a clear 'log-aggregation-enable' error and can ask the user to enable log aggregation or use a different fetch mechanism — much easier to debug than a half-parsed directory listing. Removes: - _looks_like_html, _parse_log_listing_html helpers - The bare-URL fallback path and its try/except wrapper - 4 unit tests that exercised the parser Full suite back to 243 passed (matchesfd0036c). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…
Description
No description provided
462 KiB
Languages
Python
98.1%
Shell
1%
Dockerfile
0.9%