spark-mcp/internal/admin/router_test.go

package admin

import (
	"bytes"
	"context"
	"encoding/json"
	"io"
	"net/http"
	"net/http/httptest"
	"strings"
	"testing"

	"github.com/gin-gonic/gin"

	"spark-mcp-go/internal/audit"
	"spark-mcp-go/internal/cluster"
	"spark-mcp-go/internal/storage"
)

func init() {
	gin.SetMode(gin.TestMode)
}

func newTestAdmin(t *testing.T) (*gin.Engine, *storage.ClusterRepo, *audit.Repo) {
	t.Helper()
	db, err := storage.Open(":memory:")
	if err != nil {
		t.Fatalf("open: %v", err)
	}
	t.Cleanup(func() { _ = db.Close() })
	r := gin.New()
	Mount(r, db.Clusters(), audit.NewRepo(db), []string{"good-token"})
	return r, db.Clusters(), audit.NewRepo(db)
}

func doReq(t *testing.T, r *gin.Engine, method, path, token string, body any) *httptest.ResponseRecorder {
	t.Helper()
	var rdr io.Reader
	if body != nil {
		b, _ := json.Marshal(body)
		rdr = bytes.NewReader(b)
	}
	req := httptest.NewRequest(method, path, rdr)
	if token != "" {
		req.Header.Set("Authorization", "Bearer "+token)
	}
	if body != nil {
		req.Header.Set("Content-Type", "application/json")
	}
	w := httptest.NewRecorder()
	r.ServeHTTP(w, req)
	return w
}

func fullClusterMap(id string) map[string]any {
	return map[string]any{
		"id":                        id,
		"name":                      id + "-name",
		"rm_url":                    "http://rm.example.com:8088",
		"shs_url":                   "http://shs.example.com:18080",
		"spark_submit_execute_bin":  "/usr/bin/spark-submit",
		"is_active":                 true,
		"auth_type":                 "basic",
		"auth_username":             "admin",
		"auth_password":             "real-secret",
		"ssl_verify":                false,
		"ssl_ca_bundle":             "",
		"url_allowlist":             []string{"*.example.com"},
		"default_submit_args":       []string{"--master", "yarn"},
		"rate_limit_per_min":        10,
	}
}

func TestMount_RequiresAuth(t *testing.T) {
	r, _, _ := newTestAdmin(t)

	tests := []struct {
		name   string
		method string
		path   string
		token  string
		want   int
	}{
		{"no header", "GET", "/admin/clusters", "", http.StatusUnauthorized},
		{"wrong scheme", "GET", "/admin/clusters", "Basic xxx", http.StatusUnauthorized},
		{"wrong token", "GET", "/admin/clusters", "wrong", http.StatusUnauthorized},
		{"valid token", "GET", "/admin/clusters", "good-token", http.StatusOK},
	}
	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			w := doReq(t, r, tt.method, tt.path, tt.token, nil)
			if w.Code != tt.want {
				t.Errorf("got status %d, want %d", w.Code, tt.want)
			}
		})
	}
}

func TestAdminWeb_NoTokenReturnsHTML(t *testing.T) {
	r, _, _ := newTestAdmin(t)

	// 1) /admin without token: 200 + HTML
	w := doReq(t, r, "GET", "/admin", "", nil)
	if w.Code != http.StatusOK {
		t.Fatalf("GET /admin without token: got %d, want 200", w.Code)
	}
	ct := w.Header().Get("Content-Type")
	if !strings.Contains(ct, "text/html") {
		t.Errorf("Content-Type = %q, want text/html", ct)
	}
	body := w.Body.String()
	if !strings.Contains(body, "token-modal") {
		t.Errorf("body missing token-modal element; body excerpt: %.200s", body)
	}
	if !strings.Contains(body, "Admin Token Required") {
		t.Errorf("body missing modal title")
	}

	// 2) /admin/ (trailing slash) same behavior
	w2 := doReq(t, r, "GET", "/admin/", "", nil)
	if w2.Code != http.StatusOK {
		t.Fatalf("GET /admin/ without token: got %d, want 200", w2.Code)
	}

	// 3) API routes still require auth (no token = 401)
	w3 := doReq(t, r, "GET", "/admin/clusters", "", nil)
	if w3.Code != http.StatusUnauthorized {
		t.Errorf("GET /admin/clusters without token: got %d, want 401", w3.Code)
	}

	// 4) API routes still require auth (valid token = 200)
	w4 := doReq(t, r, "GET", "/admin/clusters", "good-token", nil)
	if w4.Code != http.StatusOK {
		t.Errorf("GET /admin/clusters with good-token: got %d, want 200", w4.Code)
	}
}

func TestListClusters(t *testing.T) {
	r, _, _ := newTestAdmin(t)

	doReq(t, r, "POST", "/admin/clusters", "good-token", fullClusterMap("c1"))
	doReq(t, r, "POST", "/admin/clusters", "good-token", fullClusterMap("c2"))

	w := doReq(t, r, "GET", "/admin/clusters", "good-token", nil)
	if w.Code != http.StatusOK {
		t.Fatalf("got status %d, want %d", w.Code, http.StatusOK)
	}

	var list []map[string]any
	if err := json.Unmarshal(w.Body.Bytes(), &list); err != nil {
		t.Fatalf("unmarshal list: %v", err)
	}
	if len(list) != 2 {
		t.Errorf("got %d clusters, want 2", len(list))
	}

	for _, cl := range list {
		if _, ok := cl["auth_password"]; ok {
			t.Errorf("response must not contain auth_password")
		}
	}

	body := w.Body.String()
	if strings.Contains(body, "real-secret") {
		t.Errorf("response body leaks auth_password")
	}
}

func TestCreateCluster(t *testing.T) {
	r, _, auditRepo := newTestAdmin(t)

	w := doReq(t, r, "POST", "/admin/clusters", "good-token", fullClusterMap("c1"))
	if w.Code != http.StatusCreated {
		t.Fatalf("got status %d, want %d", w.Code, http.StatusCreated)
	}

	var cl map[string]any
	if err := json.Unmarshal(w.Body.Bytes(), &cl); err != nil {
		t.Fatalf("unmarshal cluster: %v", err)
	}
	if cl["id"] != "c1" || cl["name"] != "c1-name" {
		t.Errorf("unexpected cluster fields: id=%v name=%v", cl["id"], cl["name"])
	}

	entries, err := auditRepo.List(context.Background(), 100)
	if err != nil {
		t.Fatalf("list audit: %v", err)
	}
	if len(entries) < 1 {
		t.Fatalf("got %d audit entries, want at least 1", len(entries))
	}
	found := false
	for _, e := range entries {
		if e.Action == audit.ActionClusterCreate && e.Actor == "admin:good-tok" {
			found = true
			break
		}
	}
	if !found {
		t.Errorf("missing create audit entry from admin:good-tok")
	}
}

func TestCreateCluster_ValidationErrors(t *testing.T) {
	r, _, _ := newTestAdmin(t)

	tests := []struct {
		name string
		body map[string]any
	}{
		{
			"missing id",
			func() map[string]any {
				m := fullClusterMap("c1")
				delete(m, "id")
				return m
			}(),
		},
		{
			"missing name",
			func() map[string]any {
				m := fullClusterMap("c1")
				delete(m, "name")
				return m
			}(),
		},
		{
			"invalid auth_type",
			func() map[string]any {
				m := fullClusterMap("c1")
				m["auth_type"] = "kerberos"
				return m
			}(),
		},
		{
			"negative rate limit",
			func() map[string]any {
				m := fullClusterMap("c1")
				m["rate_limit_per_min"] = -1
				return m
			}(),
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			w := doReq(t, r, "POST", "/admin/clusters", "good-token", tt.body)
			if w.Code != http.StatusBadRequest {
				t.Errorf("got status %d, want %d", w.Code, http.StatusBadRequest)
			}
		})
	}
}

func TestGetCluster(t *testing.T) {
	r, _, _ := newTestAdmin(t)
	doReq(t, r, "POST", "/admin/clusters", "good-token", fullClusterMap("c1"))

	w := doReq(t, r, "GET", "/admin/clusters/c1", "good-token", nil)
	if w.Code != http.StatusOK {
		t.Fatalf("got status %d, want %d", w.Code, http.StatusOK)
	}
	var cl map[string]any
	if err := json.Unmarshal(w.Body.Bytes(), &cl); err != nil {
		t.Fatalf("unmarshal cluster: %v", err)
	}
	if cl["id"] != "c1" || cl["name"] != "c1-name" {
		t.Errorf("unexpected cluster fields: id=%v name=%v", cl["id"], cl["name"])
	}

	w = doReq(t, r, "GET", "/admin/clusters/not-found", "good-token", nil)
	if w.Code != http.StatusNotFound {
		t.Errorf("got status %d, want %d", w.Code, http.StatusNotFound)
	}
	var errBody map[string]any
	if err := json.Unmarshal(w.Body.Bytes(), &errBody); err != nil {
		t.Fatalf("unmarshal error body: %v", err)
	}
	if errBody["error"] != "cluster not found" {
		t.Errorf("unexpected error message: %v", errBody["error"])
	}
}

func TestUpdateCluster(t *testing.T) {
	r, _, auditRepo := newTestAdmin(t)
	doReq(t, r, "POST", "/admin/clusters", "good-token", fullClusterMap("c1"))

	update := map[string]any{
		"name":               "updated",
		"rate_limit_per_min": 99,
	}
	w := doReq(t, r, "PUT", "/admin/clusters/c1", "good-token", update)
	if w.Code != http.StatusOK {
		t.Fatalf("got status %d, want %d: %s", w.Code, http.StatusOK, w.Body.String())
	}
	var cl map[string]any
	if err := json.Unmarshal(w.Body.Bytes(), &cl); err != nil {
		t.Fatalf("unmarshal cluster: %v", err)
	}
	if cl["name"] != "updated" || cl["rate_limit_per_min"] != float64(99) {
		t.Errorf("unexpected update response: name=%v rate_limit_per_min=%v", cl["name"], cl["rate_limit_per_min"])
	}

	w = doReq(t, r, "GET", "/admin/clusters/c1", "good-token", nil)
	if w.Code != http.StatusOK {
		t.Fatalf("get after update: got status %d", w.Code)
	}
	if err := json.Unmarshal(w.Body.Bytes(), &cl); err != nil {
		t.Fatalf("unmarshal cluster after update: %v", err)
	}
	if cl["name"] != "updated" || cl["rate_limit_per_min"] != float64(99) {
		t.Errorf("cluster not updated: name=%v rate_limit_per_min=%v", cl["name"], cl["rate_limit_per_min"])
	}

	entries, err := auditRepo.List(context.Background(), 100)
	if err != nil {
		t.Fatalf("list audit: %v", err)
	}
	found := false
	for _, e := range entries {
		if e.Action == audit.ActionClusterUpdate {
			found = true
			var details map[string]any
			if err := json.Unmarshal([]byte(e.Details), &details); err != nil {
				t.Fatalf("unmarshal audit details: %v", err)
			}
			if _, ok := details["before"]; !ok {
				t.Errorf("audit details missing before")
			}
			if _, ok := details["after"]; !ok {
				t.Errorf("audit details missing after")
			}
		}
	}
	if !found {
		t.Errorf("missing update audit entry")
	}
}

func TestUpdateCluster_PreservesEmptyPassword(t *testing.T) {
	r, repo, auditRepo := newTestAdmin(t)
	doReq(t, r, "POST", "/admin/clusters", "good-token", fullClusterMap("c1"))

	// AuthPassword has json:"-", so POST cannot receive it via JSON.
	// Seed the stored password directly through the repo.
	cl, err := repo.Get(context.Background(), "c1")
	if err != nil {
		t.Fatalf("get cluster from repo: %v", err)
	}
	cl.AuthPassword = "real-secret"
	if err := repo.Update(context.Background(), cl); err != nil {
		t.Fatalf("seed password: %v", err)
	}
	// Discard the audit row produced by the seed update so it does not confuse later checks.
	_, _ = auditRepo.List(context.Background(), 100)

	update := map[string]any{
		"name": "renamed",
	}
	w := doReq(t, r, "PUT", "/admin/clusters/c1", "good-token", update)
	if w.Code != http.StatusOK {
		t.Fatalf("got status %d, want %d: %s", w.Code, http.StatusOK, w.Body.String())
	}

	if strings.Contains(w.Body.String(), "real-secret") {
		t.Errorf("update response leaks auth_password")
	}

	cl, err = repo.Get(context.Background(), "c1")
	if err != nil {
		t.Fatalf("get cluster from repo: %v", err)
	}
	if cl.AuthPassword != "real-secret" {
		t.Errorf("password changed: got %q, want %q", cl.AuthPassword, "real-secret")
	}
}

// TestUpdateCluster_PartialUpdatePreservesOtherFields verifies that PUT only
// touches fields present in the request body. Sends a full cluster via POST,
// then PUTs a body with a single field ("is_active": false) and checks every
// other field still matches the original.
func TestUpdateCluster_PartialUpdatePreservesOtherFields(t *testing.T) {
	r, repo, _ := newTestAdmin(t)
	original := fullClusterMap("c1")
	original["is_active"] = true
	original["rate_limit_per_min"] = 25
	original["url_allowlist"] = []string{"rm", "shs"}
	original["default_submit_args"] = []string{"--conf", "spark.foo=bar"}
	if w := doReq(t, r, "POST", "/admin/clusters", "good-token", original); w.Code != http.StatusCreated {
		t.Fatalf("seed POST: %d %s", w.Code, w.Body.String())
	}

	patch := map[string]any{"is_active": false}
	w := doReq(t, r, "PUT", "/admin/clusters/c1", "good-token", patch)
	if w.Code != http.StatusOK {
		t.Fatalf("PUT: %d %s", w.Code, w.Body.String())
	}

	got, err := repo.Get(context.Background(), "c1")
	if err != nil {
		t.Fatalf("get after PUT: %v", err)
	}
	if got.IsActive != false {
		t.Errorf("is_active: got %v, want false", got.IsActive)
	}
	// Every other field should equal the original.
	if got.Name != original["name"] {
		t.Errorf("name: got %q, want %q", got.Name, original["name"])
	}
	if got.RMURL != original["rm_url"] {
		t.Errorf("rm_url: got %q, want %q", got.RMURL, original["rm_url"])
	}
	if got.SHSURL != original["shs_url"] {
		t.Errorf("shs_url: got %q, want %q", got.SHSURL, original["shs_url"])
	}
	if got.SparkSubmitExecuteBin != original["spark_submit_execute_bin"] {
		t.Errorf("spark_submit_execute_bin: got %q, want %q", got.SparkSubmitExecuteBin, original["spark_submit_execute_bin"])
	}
	if got.AuthType != cluster.AuthBasic {
		t.Errorf("auth_type: got %q, want basic (preserved from seed)", got.AuthType)
	}
	if got.RateLimitPerMin != 25 {
		t.Errorf("rate_limit_per_min: got %d, want 25 (preserved from seed)", got.RateLimitPerMin)
	}
	if len(got.URLAllowlist) != 2 || got.URLAllowlist[0] != "rm" || got.URLAllowlist[1] != "shs" {
		t.Errorf("url_allowlist: got %v, want [rm shs] (preserved)", got.URLAllowlist)
	}
	if len(got.DefaultSubmitArgs) != 2 || got.DefaultSubmitArgs[0] != "--conf" {
		t.Errorf("default_submit_args: got %v, want [--conf ...] (preserved)", got.DefaultSubmitArgs)
	}
}

// TestUpdateCluster_SliceReplacement checks that an explicit non-nil slice
// in the body *replaces* the old slice (rather than appending or being
// ignored as a zero value).
func TestUpdateCluster_SliceReplacement(t *testing.T) {
	r, repo, _ := newTestAdmin(t)
	if w := doReq(t, r, "POST", "/admin/clusters", "good-token", fullClusterMap("c1")); w.Code != http.StatusCreated {
		t.Fatalf("seed POST: %d %s", w.Code, w.Body.String())
	}
	seed, _ := repo.Get(context.Background(), "c1")
	if len(seed.URLAllowlist) == 0 {
		t.Fatal("seed should have url_allowlist from fullClusterMap")
	}

	// Replace with a new single-entry list.
	patch := map[string]any{"url_allowlist": []string{"only-this"}}
	if w := doReq(t, r, "PUT", "/admin/clusters/c1", "good-token", patch); w.Code != http.StatusOK {
		t.Fatalf("PUT: %d %s", w.Code, w.Body.String())
	}
	got, _ := repo.Get(context.Background(), "c1")
	if len(got.URLAllowlist) != 1 || got.URLAllowlist[0] != "only-this" {
		t.Errorf("url_allowlist: got %v, want [only-this]", got.URLAllowlist)
	}
}

func TestDeleteCluster(t *testing.T) {
	r, _, auditRepo := newTestAdmin(t)
	doReq(t, r, "POST", "/admin/clusters", "good-token", fullClusterMap("c1"))

	w := doReq(t, r, "DELETE", "/admin/clusters/c1", "good-token", nil)
	if w.Code != http.StatusNoContent {
		t.Fatalf("got status %d, want %d", w.Code, http.StatusNoContent)
	}

	w = doReq(t, r, "GET", "/admin/clusters/c1", "good-token", nil)
	if w.Code != http.StatusNotFound {
		t.Errorf("get after delete: got status %d, want %d", w.Code, http.StatusNotFound)
	}

	entries, err := auditRepo.List(context.Background(), 100)
	if err != nil {
		t.Fatalf("list audit: %v", err)
	}
	found := false
	for _, e := range entries {
		if e.Action == audit.ActionClusterDelete {
			found = true
			break
		}
	}
	if !found {
		t.Errorf("missing delete audit entry")
	}
}

func TestListAudit(t *testing.T) {
	r, _, _ := newTestAdmin(t)
	doReq(t, r, "POST", "/admin/clusters", "good-token", fullClusterMap("c1"))
	doReq(t, r, "PUT", "/admin/clusters/c1", "good-token", map[string]any{"name": "updated"})
	doReq(t, r, "DELETE", "/admin/clusters/c1", "good-token", nil)

	w := doReq(t, r, "GET", "/admin/audit", "good-token", nil)
	if w.Code != http.StatusOK {
		t.Fatalf("got status %d, want %d", w.Code, http.StatusOK)
	}

	var entries []*audit.Entry
	if err := json.Unmarshal(w.Body.Bytes(), &entries); err != nil {
		t.Fatalf("unmarshal audit list: %v", err)
	}
	if len(entries) != 3 {
		t.Fatalf("got %d audit entries, want 3", len(entries))
	}

	wantActions := []string{string(audit.ActionClusterDelete), string(audit.ActionClusterUpdate), string(audit.ActionClusterCreate)}
	for i, want := range wantActions {
		got := string(entries[i].Action)
		if got != want {
			t.Errorf("entry[%d].action=%s, want %s", i, got, want)
		}
	}
}